Okay
  Public Ticket #576175
keeping portfolio order fixed on resize
Closed

Comments

  • Kevin started the conversation

    Hey Aether,

    Fantastic theme. I love everything about it. I just had a quick question about the portfolio widget: for some reason, when I resize the width of the browser, this shuffles the order of the portfolio images. This isn't really necessary for the responsive behavior, since the width of each 3-block of images is the same whether the tall image is on the left or right. It just needs to resize the images in place. I had a look at the Isotope documentation, and I couldn't find anything specifically related to this issue. I suspect it's something to do with the 'masonry' settings, as it mentions "item positions are likewise set with percentages to reduce adjustment transitions on window resize" if percentPosition is set to true as it recommends, and that sounds precisely like what I don't want. I couldn't find that flag anywhere in the css, though, and I thought I'd ask before digging deeply into the code if you have a quick fix to this issue. Let me know if I can answer any further questions. I have attached the HTML and some screenshots in lieu of a URL, as my site isn't up yet. Hopefully this gives you enough to recreate it.

    Edit: I guess your file uploader won't accept html. D'oh! Here's a link to the screenshots.

    http://imgur.com/a/KRUBv

    Maybe you could just tell me where to toggle percentPosition to false? Does that seem likely to fix it?

    Kevin

  •  6
    Nick replied

    Hi Kevin,

    I can\'t recreate the issue on our demo site, maybe if you could send me a link to your site so I can check out the markup? Or if you haven\'t uploaded it yet, just zip up the site and upload it here.

    Thanks,
    Nick


    aetherthemes

  • Kevin replied

    Hey Nick,

    Your 1mb limit prevents me from including more than the index.html, which won\'t really recreate the issue for you in any meaningful way. Do you have another suggestion?

    Attached files:  index.html.zip

  •  6
    Nick replied

    There seems to be an issue with the HTML markup, the portfolio section is duplicated from what I can see, and you can\'t have more than one element with the same ID (which is the case with your markup, ID of section 5 is duplicated). Can you maybe upload the zip of the full site on dropbox, so I can actually see the behaviour when opened in the browser?

    Thanks,
    Nick


    aetherthemes

  • Kevin replied

    Hey Nick,

    You were right about the HTML issues, although I\'m not sure that was entirely responsible for the issue I had. The issue I was having earlier re: slideshow contents shifting position on resize appears to be at least partly a side-effect of the retina.js optimization script. I do have a retina display, and it\'s possible the script was only kicking in at certain viewport resolutions. I haven\'t verified this to be absolutely sure (it\'s a bit hard to read), but disabling the script has eliminated the problem I was having. In any case, awesome! It\'s looking slick.

    Can I ask your advice on one error I can\'t figure out? Have a look at the contact form widget at the bottom of the page of my staging server: dev.searchandcipher.com. The post.php script is successfully loading, successfully validating that the email address conforms to a regexpr (e.g. makes sure it contains an @), but it\'s not successful for valid inputs -- it just says \"ERROR\" in that case. I don\'t know if this is a server config issue or something to do with the code itself, which I haven\'t modified too extensively from the original theme. A few notes/observations I\'ve made which may or may not be helpful:

    1. My dev console prints an error about \'invalid email address\' immediately on page load. It occurs when I load the index.html file of the original, unmodified Aether Theme as well, although I don\'t think that necessarily implies the theme itself is at fault. (I wouldn\'t expect PHP to run seamlessly from the fileserver)

    2. My server\'s a DigitalOcean LAMP droplet. It has PHP installed and should play well with AJAX by default, no special server config necessary. Here\'s an AJAX slideshow widget on the same server executing server-side PHP without a problem: dev.searchandcipher.com/ichabod

    3. I\'m also seeing a Google Maps API warning in the console about \'sensor not required\' – any idea what this is about? It seems possible that it\'s related, but I don\'t know. The contact widget and the map are embedded in the same container. Dunno.

    Any advice appreciated. The theme is ridiculously awesome, btw, thank you so much for making such a beautiful template!

    Kevin

  • Kevin replied

    Hey Nick,

    FYI there appears to be a bug on line 68 of the original post.php script:

    if(mail($address, $e_subject, $msg, $headers)) {

    There is no function \'mail\' defined in the template, unless I somehow modified mine by accident (I didn\'t, did I?), so this will never be true. A quickfix is to replace this line with \"if (isEmail($email)) {\". I\'ll rewrite this to check for non-empty subject, message, and headers once I get my mailserver configured.

    Kevin

  • Kevin replied

    Success! I retract my earlier bug report. Apparently email() is a primitive PHP function! It was returning false for all inputs because I needed to install sendmail on my server and provide the usual \"/usr/sbin/sendmail -i -t\" path for it in my php.ini file. Sorry for the false alarm. I only use PHP when I absolutely can\'t avoid it :P

  •  6
    Nick replied

    Hey Kevin,

    Can you tell me if all the issues you were experiencing with the mail script are solved?

    Thanks,
    Nick


    aetherthemes